Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: change project name config tag, add pkg/model/file.ProjectNameMixin #1609

Merged

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Jul 23, 2020

This PR adds pkg/model/file.ProjectNameMixin, which will inject the Config.ProjectName into any structs that embed this mixin.

/cc @joelanford @pwittrock

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

// InjectProjectName implements HasProjectName.
func (m *ProjectNameMixin) InjectProjectName(projectName string) {
if m.ProjectName == "" {
m.ProjectName = strings.ToLower(projectName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to be calling strings.ToLower at this point? This might be confusing to someone seeing projectName: MyProject in their PROJECT file and then seeing myproject in their scaffolded files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any concept of PROJECT file validation anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with always lowercasing projectName.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any concept of PROJECT file validation anywhere

No. This file is assumed to be more or less "valid" after init.

the Config.ProjectName into any structs that embed this mixin.
@estroz estroz force-pushed the feature/project-name-mixin branch from 2104134 to f028d0a Compare July 23, 2020 20:27
@joelanford
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 353f7a6 into kubernetes-sigs:master Jul 23, 2020
@estroz estroz deleted the feature/project-name-mixin branch July 23, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants